Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NVDA causes firefox to crash in nsAccUtils::GetHeaderCellsFor #807

Closed
nvaccessAuto opened this issue Aug 4, 2010 · 8 comments
Closed

NVDA causes firefox to crash in nsAccUtils::GetHeaderCellsFor #807

nvaccessAuto opened this issue Aug 4, 2010 · 8 comments

Comments

@nvaccessAuto
Copy link

Reported by aleksey_s on 2010-08-04 11:13
I reported it on the mailing list, but i've found recently that it is also reproduceable on my system.
site: http://vkontakte.ru
related crash IDS:
friend's system: bp-db2ec6e1-7506-4da4-95ab-472282100804
My laptop: bp-3ab9959e-dc34-4be6-bfe8-b0d392100804

@nvaccessAuto
Copy link
Author

Comment 1 by aleksey_s on 2010-08-04 11:14
It doesn't occur with 2010.2.

@nvaccessAuto
Copy link
Author

Comment 2 by jteh on 2010-08-04 11:41
This is a bug in Mozilla, which I reported yesterday. See MozillaBug:583952. I don't want to revert this code in NVDA because it will eventually be fixed in Firefox, and if we revert it now, we'll lose it for 2010.2 altogether.

@nvaccessAuto
Copy link
Author

Comment 3 by aleksey_s on 2010-08-11 14:14
This one is definitely a show-stopper for 2010.2. Too many sites where it crashes.
Changes:
Milestone changed from None to 2010.2

@nvaccessAuto
Copy link
Author

Comment 4 by jteh on 2010-08-25 22:49
MozillaBug:583952 is now fixed in the latest Firefox 4 nightly. I'd appreciate it if people could test this with various sites that crashed.

Lex, I was never able to reproduce it on the site you provided, but perhaps it appears differently on my system due to locale.

This fix isn't yet backported to Firefox 3.6.x. If the fix isn't in a final Firefox 3.6.x release by the time we want to release NVDA 2010.2, I'll still have to find a work around on our side. Leaving open until this gets resolved one way or another for 3.6.x.

@nvaccessAuto
Copy link
Author

Comment 5 by jteh on 2010-08-29 21:21
This fix will be in Firefox 3.6.10. Not sure when that will be available to users.

@nvaccessAuto
Copy link
Author

Comment 6 by jteh on 2010-09-10 05:14
We need to work around this because 3.6.10 will not be out before 2010.2beta1 comes out.

Unfortunately, the only thing we can do is completely disable fetching of table headers for Gecko <= 1.9.2.9. We can do this by querying the toolkit version from IAccessibleApplication.

@nvaccessAuto
Copy link
Author

Comment 7 by jteh on 2010-09-14 01:04
Done in e6ccf99.
Changes:
State: closed

@nvaccessAuto
Copy link
Author

Comment 8 by jteh on 2010-09-16 01:46
Unfortunately, this fix won't be in Firefox 3.6.10 after all, but will instead be deferred until 3.6.11. d2e2ce5 updates the code to handle this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants