Ticket #591 (closed defect: fixed)
Strings never freed when retrieving text from virtual buffers
| Reported by: | jteh | Owned by: | mdcurran |
|---|---|---|---|
| Priority: | major | Milestone: | 2010.1 |
| Component: | Browse mode | Version: | |
| Keywords: | memoryLeak | Cc: | |
| Operating system: | Blocked by: | ||
| Blocking: |
Description
Str:
- Open http://www.nvda-project.org/ in Firefox and move focus inside the buffer.
- Press NVDA+ctrl+z to activate the Python console.
- Type:
ti = focus.virtualBuffer.makeTextInfo("all") for i in xrange(20000): t = ti.text
Actual: Massive memory leak (NVDA shoots up to about 300 mb here).
Expected: Uh... no memory leak.
Note that closing the browser doesn't clean this up.
This happens because VBuf_getTextInRange allocates a string on the server side which is then marshalled to the client but never freed. We figured that ctypes was freeing the string when it was garbage collected by Python (which is actually incorrect, since ctypes didn't allocate it), but it seems that ctypes (correctly) doesn't do this after all.


Fixed in changeset:main,3397 with some cleanup in changeset:main,3398.