Ticket #470 (closed task: fixed)

Opened 2 years ago

Last modified 2 years ago

Move virtual buffer class determination into NVDAObjects

Reported by: jteh Owned by:
Priority: minor Milestone:
Component: Browse mode Version: development
Keywords: Cc:
Operating system: Blocked by:
Blocking:

Description

Currently, we determine what class should be used for virtual buffers in virtualBufferHandler.update(). Moving this determination to NVDAObjects would provide much better abstraction and object encapsulation. Also, NVDAObjects may already have much of the information needed to determine their virtual buffer class. A virtualBufferClass (or similar) attribute should be provided on NVDAObjects which returns the class to be used for virtual buffers.

Change History

comment:1 Changed 2 years ago by mdcurran

bzr branch:
 http://bzr.nvaccess.org/nvda/virtualBufferClassProperty

Currently all virtualBuffer classes have been implemented in their respective NVDAObjects. virtualBufferHandler.update has been changed to use NVDAObject.virtualBufferClass if it is implemented, and all previous virtualBuffer choice code has been removed.

comment:2 Changed 2 years ago by jteh

  • Status changed from new to closed
  • Resolution set to fixed

Merged in r3384.

Note: See TracTickets for help on using tickets.