Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Seika Braille, now supports old protocol #2606

Closed
nvaccessAuto opened this issue Aug 18, 2012 · 4 comments
Closed

Seika Braille, now supports old protocol #2606

nvaccessAuto opened this issue Aug 18, 2012 · 4 comments
Assignees
@jcsteh
Labels
component/braille enhancement
Milestone
2012.3

Comments

@nvaccessAuto
Copy link

Reported by Ulf on 2012-08-18 13:18
Michel Such reports an error in my driver - the braille display of Michel has an older firmware version. So I add this protocol and Michel makes the test
@nvaccessAuto
Copy link
Author

Attachment seika.py added by Ulf on 2012-08-18 13:20
Description:

@nvaccessAuto
Copy link
Author

Comment 1 by jteh on 2012-08-20 08:57
I'm unclear: has Michel reported that this new driver fixes the issue?
Changes:
Milestone changed from None to 2012.3

@nvaccessAuto
Copy link
Author

Comment 2 by jteh on 2012-08-22 03:19
Committed in cf7b84a with a few changes by me:

  • Commented out or changed log.info calls to log.debug. log.info should only be used for info relevant to users.
  • Removed unnecessary s40 variable at module level.

Also, I just noticed that you time.sleep(0.1) after probing the display. Is this necessary? The .read() call will block until the timeout (0.2) expires, so it seems like this imposes an unnecessary delay.
Changes:
State: closed

@nvaccessAuto
Copy link
Author

Comment 3 by Ulf on 2012-08-22 14:14
Hello, I have tested it without the sleep and it works, so I think it is not necessary.

@nvaccessAuto nvaccessAuto added this to the 2012.3 milestone Nov 10, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jcsteh jcsteh

Labels
component/braille enhancement
Projects
None yet
Milestone
2012.3
Development

No branches or pull requests
2 participants
@jcsteh @nvaccessAuto