Ticket #249 (closed enhancement: fixed)

Opened 3 years ago

Last modified 3 years ago

For long text selections, announce number of characters selected instead of announcing the entire selection

Reported by: aleksey_s Owned by: aleksey_s
Priority: minor Milestone: 0.6p3
Component: Core Version: development
Keywords: Cc:
Operating system: Blocked by:
Blocking:

Description

Looks as some synthesizers can lag on long portion of text. also, i am assuming anybody doesn't want listen to all document when "select all" comand is performed.

Attachments

selections.patch Download (3.6 KB) - added by aleksey_s 3 years ago.
my workaround

Change History

Changed 3 years ago by aleksey_s

my workaround

comment:1 follow-up: ↓ 2 Changed 3 years ago by jteh

I have made some modifications to your work. I've pushed them into a bzr branch called longSelections on bzr.nvaccess.org.

Also, should the reportCurrentSelection script truncate the selection according to this patch? This would be consistent behaviour. However, one could also argue that if users request reporting of the selection, they really want the whole selection reported.

comment:2 in reply to: ↑ 1 ; follow-up: ↓ 3 Changed 3 years ago by aleksey_s

Replying to jteh:

Also, should the reportCurrentSelection script truncate the selection according to this patch? This would be consistent behaviour. However, one could also argue that if users request reporting of the selection, they really want the whole selection reported.

no, when reportSelection is called whole selection might be spoken. however, i suggest don't use speakSelectionChange() for this, it is not required. we can just receive appropriate textInfo and speak it. in this way it will be easy to add something as "the current selection is" if it is required for some users, when verbosity levels will be implemented.

comment:3 in reply to: ↑ 2 Changed 3 years ago by aleksey_s

Replying to aleksey_s:

no, when reportSelection is called whole selection might be spoken. however, i suggest don't use speakSelectionChange() for this, it is not required. we can just receive appropriate textInfo and speak it. in this way it will be easy to add something as "the current selection is" if it is required for some users, when verbosity levels will be implemented.

sorry for inconsistency, this behavior is allready used

comment:4 follow-up: ↓ 5 Changed 3 years ago by jteh

So are you happy with the current state of this patch, including my changes? If so, I will commit.

comment:5 in reply to: ↑ 4 Changed 3 years ago by aleksey_s

Replying to jteh:

So are you happy with the current state of this patch, including my changes? If so, I will commit.

absolutely.

comment:6 Changed 3 years ago by jteh

  • Status changed from new to closed
  • Resolution set to fixed

Merged in svn r2557. Thanks for your work.

comment:7 Changed 3 years ago by jteh

  • Summary changed from NVDA may doesn't speak long selection, instead announce number of characters selected to For long text selections, announce number of characters selected instead of announcing the entire selection
Note: See TracTickets for help on using tickets.