Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression in both beta 1 and latest snap re IE8 forgetting position in last page visited #1604

Closed
nvaccessAuto opened this issue Jun 25, 2011 · 9 comments

Comments

@nvaccessAuto
Copy link

Reported by briang1 on 2011-06-25 14:37
When in Firefox 3.6 its normal to expect that say, taking the link from the nvda download page to the whats new in page, and then doing alt left to come back one ends up still on the link you just pressed.

In IE 8 this no longer occurs . There are differing symptoms according to the version you are running. In th the beta1 you find you are below the link somewhere, but in the latest snaps you go to the top of the page.

I'm not sure where this actually broke though. I will investigat further as it works fine in 2011.1.1. I have now tested this on two machines

@nvaccessAuto
Copy link
Author

Comment 1 by briang1 on 2011-06-25 22:30

Hi, the best I can do for you on this regression is that it works in..
nvda_snapshot_main-4220_installer.exe

But fails in this one...
nvda_snapshot_main-4246_installer.exe
And thereafter in slightly different ways it seems, but mostly reverting to top of page.

It could be that the differences occur due to frames on the page, I have not checked for this.

Changes:
Changed title from "Regression in both beta 1 and latest snap re forgetting position in last page visited" to "Regression in both beta 1 and latest snap re IE8 forgetting position in last page visited"

@nvaccessAuto
Copy link
Author

Comment 2 by mdcurran on 2011-06-27 00:48
In fa59fc8 its pretty flaky for me in IE9 (i.e. it doesn't always work). If it really did break for IE8 in that range, I'm possibly guessing 28d58f9, cca0898 or d946992. I do not have IE8 right now to test.

@nvaccessAuto
Copy link
Author

Comment 3 by briang1 on 2011-06-27 08:32
I have added a log file of the two versions, but as I note, its hard to see what is going on due to the fact that nvda says its speaking whole pages when its actually not! Its interupted. However by then all the text has spewed to the speak buffer it seems.Well I can definitely say what I say above is true on several machines running IE8. The page I used just now to check was the download page for nvda and used the whats new links.

If you want to provide me with snaps just after the prime suspects I can test them fairly easily.

@nvaccessAuto
Copy link
Author

Attachment multi-log of not going back to point on IE8.log added by briang1 on 2011-06-27 10:36
Description:
Two logs with comments Not very helpful!

@nvaccessAuto
Copy link
Author

Comment 4 by briang1 on 2011-06-29 12:07
Its very irritating in sites like Amazon with its huge number of links!

@nvaccessAuto
Copy link
Author

Comment 5 by jteh on 2011-06-30 02:58
Confirmed. Worked in 2011.1.1, now broken in several weird and wonderful ways.
Changes:
Milestone changed from None to 2011.2

@nvaccessAuto
Copy link
Author

Comment 6 by jteh on 2011-06-30 05:03
Regression probably caused by 739375b (but this was not an incorrect change).

Fixed in a4bd6e8.
Changes:
State: closed

@nvaccessAuto
Copy link
Author

Comment 7 by briang1 on 2011-06-30 17:52
The function now works, but noticed the following errors in IE8 that might be caused by it..
This error gets triggered if IE closes under some circumstances by the way,
due to this fix I imagine. Should not matter once beeps are suppressed in
the release though.

This error happens presumably as the system has not noticed that ie has been
asked to close.

IO - inputCore.InputManager.executeGesture (12:09:29):

Input: kb(desktop):alt+f4

IO - speech.speak (12:09:29):

Speaking [- inputCore.InputManager.executeGesture (12:09:31):

Input: kb(desktop):windows+m

DEBUG - appModuleHandler.update (12:09:31):

application iexplore closed

ERROR - eventHandler.executeEvent (12:09:31):

error executing event: gainFocus on
<NVDAObjects.IAccessible.sysListView32.ListItem object at 0x01CAE4F0> with
extra args of {}

Traceback (most recent call last):

File "eventHandler.pyc", line 131, in executeEvent

File "eventHandler.pyc", line 144, in doPreGainFocus

File "api.pyc", line 116, in setFocusObject

File "treeInterceptorHandler.pyc", line 44, in cleanup

File "treeInterceptorHandler.pyc", line 51, in killTreeInterceptor

File "virtualBuffers__init__.pyc", line 528, in terminate

AttributeError: 'NoneType' object has no attribute
'_vbufRememberedCaretPositions'

Suspect this error might be triggered with this update as well, but not sure..
IO - inputCore.InputManager.executeGesture (11:34:50):
Input: kb(desktop):downArrow
IO - speech.speak (11:34:50):
Speaking [u'out of list out of table link Change log'](u'Taskbar']

IO)
IO - inputCore.InputManager.executeGesture (11:34:53):
Input: kb(desktop):enter
IO - tones.beep (11:34:54):
Beep at pitch 113.092520932, for 40 ms, left volume 50, right volume 50
IO - speech.speak (11:34:54):
Speaking percent'
IO - tones.beep (11:34:56):
Beep at pitch 1760.0, for 40 ms, left volume 50, right volume 50
IO - speech.speak (11:34:56):
Speaking percent'
DEBUG - treeInterceptorHandler.killTreeInterceptor (11:34:57):
Killed treeInterceptor: <virtualBuffers.MSHTML.MSHTML object at 0x03ADFC50>
DEBUG - treeInterceptorHandler.update (11:34:57):
Adding new treeInterceptor to runningTable: <virtualBuffers.MSHTML.MSHTML
object at 0x03B13B70>
IO - speech.speak (11:34:59):
Speaking - main (log) document'
IO - speech.speak (11:34:59):
Speaking - main (log)'
DEBUG - queueHandler.registerGeneratorObject (11:34:59):
Adding generator 7
IO - speech.speak (11:34:59):
Speaking u'banner landmark link graphic align center
NVDA Logo', IndexCommand(2), u'search landmark edit align left button
align center Search', IndexCommand(3), u'link graphic align left
Donate', IndexCommand(4), u'navigation landmark list with 7 items align
center \u2022 link Home \u2022 link About \u2022 link Download
\u2022 link Documentation \u2022 link Recognition \u2022 link
Community \u2022 link Development', IndexCommand(5), u'out of list main
landmark heading level 1 link align left source: link main @ link
main,4518 \n', IndexCommand(6), u'Revision Log Mode:', IndexCommand(7),
u'radio button checked Stop on copy ', IndexCommand(8), u'radio button
not checked Follow copies ', IndexCommand(9), u'radio button not
checked Show only adds and deletes ', IndexCommand(10), u'View log
starting at edit main,4518 and back to edit \n', IndexCommand(11),
u'Show at most edit 100 revisions per page. \n'

IO - inputCore.InputManager.executeGesture (11:35:02):
Input: kb(desktop):alt+leftArrow
DEBUG - treeInterceptorHandler.killTreeInterceptor (11:35:02):
Killed treeInterceptor: <virtualBuffers.MSHTML.MSHTML object at 0x03B13B70>
DEBUG - treeInterceptorHandler.update (11:35:02):
Adding new treeInterceptor to runningTable: <virtualBuffers.MSHTML.MSHTML
object at 0x03AD6E30>
IO - speech.speak (11:35:03):
Speaking - Snapshots document'
ERROR - eventHandler.executeEvent (11:35:03):
error executing event: caret on
<NVDAObjects.Dynamic_EditableTextWithoutAutoSelectDetectionBodyMSHTMLIAccessible
object at 0x03B131B0> with extra args of {}
Traceback (most recent call last):
File "eventHandler.pyc", line 136, in executeEvent
File "eventHandler.pyc", line 84, in init
File "eventHandler.pyc", line 91, in next
File "NVDAObjects\IAccessible\MSHTML.pyc", line 314, in event_caret
File "NVDAObjects__init__.pyc", line 855, in makeTextInfo
File "NVDAObjects\IAccessible\MSHTML.pyc", line 200, in init
RuntimeError: Only works with currently selected element
IO - speech.speak (11:35:03):
Speaking - Snapshots'
DEBUG - queueHandler.registerGeneratorObject (11:35:03):
Adding generator 8

It happens like this sometimes...

Speaking Accessible Search - '
IO - speech.speak (10:57:03):
Speaking percent'
DEBUG - treeInterceptorHandler.update (10:57:04):
Adding new treeInterceptor to runningTable: <virtualBuffers.MSHTML.MSHTML
object at 0x03CD2C30>
IO - speech.speak (10:57:04):
Speaking Accessible Search document'
IO - speech.speak (10:57:04):
Speaking Accessible Search document'
ERROR - eventHandler.executeEvent (10:57:04):
error executing event: caret on
<NVDAObjects.Dynamic_EditableTextWithoutAutoSelectDetectionBodyMSHTMLIAccessible
object at 0x03CEE3F0> with extra args of {}
Traceback (most recent call last):
File "eventHandler.pyc", line 136, in executeEvent
File "eventHandler.pyc", line 84, in init
File "eventHandler.pyc", line 91, in next
File "NVDAObjects\IAccessible\MSHTML.pyc", line 314, in event_caret
File "NVDAObjects__init__.pyc", line 855, in makeTextInfo
File "NVDAObjects\IAccessible\MSHTML.pyc", line 200, in init
RuntimeError: Only works with currently selected element
IO - speech.speak (10:57:04):
Speaking edit Search'
IO - speech.speak (10:57:04):
Speaking [- speech.speak (10:57:04):
Speaking [u'Search edit Search'](u'blank']
IO)
IO - speech.speak (10:57:04):
Speaking [u'blank']
IO - speech.speak (10:57:04):

None of this seems destructive. Also posted in dev group in case others wish to comment.

Note got the error as this ticket page loaded as well.

@nvaccessAuto
Copy link
Author

Comment 8 by jteh on 2011-07-01 01:57
First error fixed in 9ea3b6c. Second is unrelated to this ticket, but anyway, it was fixed in 79d52c9.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant